Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Use explicit resource order when assocating agents#2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromresource-order
Jun 10, 2022

Conversation

kylecarbs
Copy link
Member

This cleans up agent association code to explicitly map a single
agent to a single resource. This willfix#1884, and unblock
a prospect from beginning a POC.

@kylecarbskylecarbs self-assigned thisJun 9, 2022
@kylecarbskylecarbsforce-pushed theresource-order branch 2 times, most recently fromd94e224 to1033852CompareJune 9, 2022 21:51
Copy link
Contributor

@f0sself0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tests lgtm

This cleans up agent association code to explicitly map a singleagent to a single resource. This willfix#1884, and unblocka prospect from beginning a POC.
@kylecarbskylecarbsenabled auto-merge (squash)June 9, 2022 22:35
Comment on lines +54 to +55
var findTerraformResources func(mod *tfjson.StateModule)
findTerraformResources = func(mod *tfjson.StateModule) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
varfindTerraformResourcesfunc(mod*tfjson.StateModule)
findTerraformResources=func(mod*tfjson.StateModule) {
findTerraformResources:=func(mod*tfjson.StateModule) {

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can't do that because it calls itself ;p

@kylecarbskylecarbs merged commitf9290b0 intomainJun 10, 2022
@kylecarbskylecarbs deleted the resource-order branchJune 10, 2022 15:47
kylecarbs added a commit that referenced this pull requestJun 10, 2022
This cleans up agent association code to explicitly map a singleagent to a single resource. This willfix#1884, and unblocka prospect from beginning a POC.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@f0sself0sself0ssel approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@deansheather@f0ssel

[8]ページ先頭

©2009-2025 Movatter.jp