NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

feat: Add "coder" CLI#221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kylecarbs merged 8 commits intomainfromcli

Feb 10, 2022

Merged

feat: Add "coder" CLI#221

kylecarbs merged 8 commits intomainfromcli

Feb 10, 2022

Conversation

Copy link

Member

kylecarbs commentedFeb 9, 2022•
edited
Loading

Scaffolds the base of the CLI, and establishes a basic design for the IO.

feat: Add "coder" CLI

d6a1eb8

kylecarbs requested a review frombryphe-coder

February 9, 2022 19:01

kylecarbs self-assigned this

Feb 9, 2022

Copy link

codecovbot commentedFeb 9, 2022•
edited
Loading

Codecov Report

Merging#221 (6aec3a1) intomain (277318b) willdecrease coverage by1.28%.
The diff coverage is52.69%.

@@            Coverage Diff             @@##             main     #221      +/-   ##==========================================- Coverage   68.43%   67.14%   -1.29%==========================================  Files         111      120       +9       Lines        6003     6484     +481       Branches       67       67              ==========================================+ Hits         4108     4354     +246- Misses       1507     1711     +204- Partials      388      419      +31

Flag	Coverage Δ
unittest-go-macos-latest	`65.02% <52.69%> (-1.42%)`	⬇️
unittest-go-ubuntu-latest	`66.35% <52.69%> (-1.28%)`	⬇️
unittest-go-windows-latest	`66.07% <67.32%> (+0.09%)`	⬆️
unittest-js	`64.76% <ø> (ø)`

Impacted Files	Coverage Δ
cli/projectcreate.go	`3.60% <3.60%> (ø)`
codersdk/users.go	`68.96% <53.84%> (-2.66%)`	⬇️
cli/login.go	`54.90% <54.90%> (ø)`
cli/config/file.go	`61.76% <61.76%> (ø)`
cli/projectplan.go	`62.50% <62.50%> (ø)`
cli/projectupdate.go	`62.50% <62.50%> (ø)`
coderd/users.go	`59.68% <64.70%> (+0.36%)`	⬆️
cli/root.go	`69.74% <69.74%> (ø)`
coderd/cmd/root.go	`81.69% <77.77%> (-4.43%)`	⬇️
cli/projects.go	`100.00% <100.00%> (ø)`
... and6 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update277318b...6aec3a1. Read thecomment docs.

bryphe-coder reviewed

Feb 9, 2022

View reviewed changes

cli/config/file_test.go Outdated

		require.NoError(t,err)
		data,err:=root.Session().Read()
		require.NoError(t,err)
		require.Equal(t,"test",string(data))

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I didn't realize GH actions could push failures inline - that's kind of cool (re: lint errors on this line)

bryphe-coder reviewed

Feb 9, 2022

View reviewed changes

cli/root.go

Comment on lines +27 to +32

		Long:` ▄█▀ ▀█▄
		▄▄ ▀▀▀ █▌ ██▀▀█▄ ▐█
		▄▄██▀▀█▄▄▄ ██ ██ █▀▀█ ▐█▀▀██ ▄█▀▀█ █▀▀
		█▌ ▄▌ ▐█ █▌ ▀█▄▄▄█▌ █ █ ▐█ ██ ██▀▀ █
		██████▀▄█ ▀▀▀▀ ▀▀▀▀ ▀▀▀▀▀ ▀▀▀▀ ▀
		`+color.New(color.Underline).Sprint("Self-hosted developer workspaces on your infra")+`

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice 😎

bryphe-coder reviewed

Feb 9, 2022

View reviewed changes

cli/root.go

		return coderd.Organization{},nil
		}
		// For now, we won't use the config to set this.
		// Eventually, we will support changing using "coder switch <org>"

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sounds good.

bryphe-coder reviewed

Feb 9, 2022

View reviewed changes

cli/login.go

		}

		client:=codersdk.New(serverURL)
		hasInitialUser,err:=client.HasInitialUser(cmd.Context())

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's cool that it guides you through set-up the first time you login, if there isn't a user available yet.

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Agreed! I wanted the full flow to be available. I added tests now too!

bryphe-coder reviewed

Feb 9, 2022

View reviewed changes

cli/root.go

		}

		funccreateClient(cmdcobra.Command) (codersdk.Client,error) {
		root:=createConfig(cmd)

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks like we're sticking with the write-token-to-file approach - do you think it's worth logging an issue to use platform-specific tools likeKeychain,wincred,SecretStore, etc to persist the credentials? For example, using the credential helpers here:https://github.com/docker/docker-credential-helpers ?

Copy link

MemberAuthor

kylecarbsFeb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it's wise to use something else, yeah. I was going to do this post-black triangle. I'll make an issue!

bryphe-coder reviewed

Feb 9, 2022

View reviewed changes

cli/login.go


		funclogin()*cobra.Command {
		return&cobra.Command{
		Use:"login <url>",

Copy link

Contributor

bryphe-coderFeb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should have tests in place that run the CLI on Windows / Linux / Mac - maybe that would be a good-first-issue for getting someone on-boarded in the repo?