Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

do not merge: prototyping of v2 workspaces of page#219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
bryphe-coder wants to merge14 commits intomainfrombryphe/prototype/workspaces-page

Conversation

bryphe-coder
Copy link
Contributor

I'm embarrassed to even open up this PR, because it's prototyping for the v2 workspaces page:

image

Don't look at the code too hard 😄 I'll be breaking this up and refining it across several PRs.

This is mostly bringing in the components and styles from v1 that we'd need to have a similar experience.

jawnsy reacted with heart emojijawnsy reacted with rocket emoji
@bryphe-coderbryphe-coder self-assigned thisFeb 9, 2022
@bryphe-coderbryphe-coder changed the titlenomerge: Hacky prototype of v2 workspaces of pagedo not merge: hacky prototype of v2 workspaces of pageFeb 9, 2022
@bryphe-coderbryphe-coder changed the titledo not merge: hacky prototype of v2 workspaces of pagedo not merge: prototyping of v2 workspaces of pageFeb 9, 2022
@codecov
Copy link

codecovbot commentedFeb 9, 2022•
edited
Loading

Codecov Report

Merging#219 (89947c9) intomain (c44d036) willincrease coverage by0.26%.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff             @@##             main     #219      +/-   ##==========================================+ Coverage   68.31%   68.57%   +0.26%==========================================  Files         111       53      -58       Lines        6003     5356     -647       Branches       67        0      -67     ==========================================- Hits         4101     3673     -428+ Misses       1512     1304     -208+ Partials      390      379      -11
FlagCoverage Δ
unittest-go-macos-latest66.13% <ø> (-0.15%)⬇️
unittest-go-ubuntu-latest67.60% <ø> (+0.09%)⬆️
unittest-go-windows-latest66.03% <ø> (+0.10%)⬆️
unittest-js?
Impacted FilesCoverage Δ
peer/conn.go78.71% <0.00%> (-1.03%)⬇️
provisionerd/provisionerd.go68.90% <0.00%> (-1.02%)⬇️
site/components/index.tsx
...pages/projects/[organization]/[project]/create.tsx
site/components/Form/index.ts
site/.storybook/main.js
site/test_helpers/index.tsx
site/components/Navbar/UserDropdown.tsx
site/test_helpers/mocks.ts
site/components/ErrorSummary/index.tsx
... and50 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatec44d036...89947c9. Read thecomment docs.

bryphe-coder added a commit that referenced this pull requestFeb 16, 2022
This implements an initial route for the workspaces page at `/workspaces/{user}/{workspace}`, and an additional storybook entry:<img width="1723" alt="image" src="https://user-images.githubusercontent.com/88213859/153271281-801a5889-f60e-458c-809f-396a2d6385fa.png">Just the header is rendering right now. Will be adding the additional sections prototyped in#219 in subsequent PRsRelated to#67
@stale
Copy link

stalebot commentedFeb 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stalestalebot added the staleThis issue is like stale bread. labelFeb 23, 2022
@stalestalebot closed thisFeb 28, 2022
@kylecarbskylecarbs deleted the bryphe/prototype/workspaces-page branchMarch 23, 2022 16:24
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@aslilacaslilacAwaiting requested review from aslilacaslilac will be requested when the pull request is marked ready for reviewaslilac is a code owner

@ParkreinerParkreinerAwaiting requested review from ParkreinerParkreiner will be requested when the pull request is marked ready for reviewParkreiner is a code owner

Assignees

No one assigned

Labels

staleThis issue is like stale bread.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bryphe-coder
[8]ページ先頭
©2009-2025 Movatter.jp