- Notifications
You must be signed in to change notification settings - Fork928
fix: Improve Terraform agent<->resource association testing#2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There were a few bugs with multiple agent association this fixes,and it adds thorough tests using real Terraform state and plans.
b7eb9b5 tob208e8eComparebpmct commentedJun 8, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Does this encompass the bugs discovered in#1884? |
@bpmct yup! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
go code lgtm, can't speak to the tf files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The test cases are very epic
| set -euo pipefail | ||
| cd "$(dirname "${BASH_SOURCE[0]}")" | ||
| for d in */; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I appreciate that you've included the script for this :)
This was regressed in#2187. There was bad testing around thisbefore, and this should prevent a similiar situation from happeningagain!
This was regressed in#2187. There was bad testing around thisbefore, and this should prevent a similiar situation from happeningagain!
This was regressed in#2187. There was bad testing around thisbefore, and this should prevent a similiar situation from happeningagain!
This was regressed in#2187. There was bad testing around thisbefore, and this should prevent a similiar situation from happeningagain!
Uh oh!
There was an error while loading.Please reload this page.
An agent could be associated with multiple resources prior to this, which broke all workspace access (and doesn't make any sense). This adds tests based on Terraform output. The raw Terraform statefiles are pushed for fast testing, and can be iterated on by editing the Terraform and running
generate.sh.This should improve test times and provide a much more stable solution for resource association!