- Notifications
You must be signed in to change notification settings - Fork928
fix: increase default extension time#2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -47,7 +47,7 @@ describe("util > workspace", () => { | |||
| [ | |||
| "2022-06-02T14:56:34Z", | |||
| { | |||
| deadline: "2022-06-02T16:26:34Z", | |||
| deadline: "2022-06-02T18:56:34Z", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Review:
It was previously 90 minutes, now it's 4 hours. So this adds 2.5 hours.
| @@ -56,7 +56,7 @@ describe("util > workspace", () => { | |||
| [ | |||
| "2022-06-02T10:56:20-04:00", | |||
| { | |||
| deadline: "2022-06-02T16:26:20Z", | |||
| deadline: "2022-06-02T18:56:20Z", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Review:
It was previously 90 minutes, now it's 4 hours. So this adds 2.5 hours.
This does not fullyclose#2141, but builds upon#2171 to fulfill each
of the UX requests.
A next step (probably as a separate ticket) is to allow customizing
extension time pre-emptively.