- Notifications
You must be signed in to change notification settings - Fork928
fix: show explicit schedule stop time#2171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This does not fully resolve all requests in#2141, but just the piece ofwhen the workspace is actually stopping.Next, we will adjust the default extension from 90 minutes to 4 hours.Lastly, we can look at customizing the extension time in the extensionflow or with a pre-emptive prompt next to the stop time.
| } | ||
| return "Manual" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Review:
Just meeting the FE code convention of using explicitelse here.
| import duration from "dayjs/plugin/duration" | ||
| import relativeTime from "dayjs/plugin/relativeTime" | ||
| import timezone from "dayjs/plugin/timezone" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Review:
Both are needed to manipulate time in the user's timezone and display timezone information (specifically where you see.format("z")
Summary:Uncaught from the change in#2171
Summary:Uncaught from the change in#2171
This does not fully resolve all requests in#2141, but just the piece ofwhen the workspace is actually stopping.Next, we will adjust the default extension from 90 minutes to 4 hours.Lastly, we can look at customizing the extension time in the extensionflow or with a pre-emptive prompt next to the stop time.
Summary:Uncaught from the change in#2171
This does not fully resolve all requests in#2141, but just the piece of
when the workspace is actually stopping.
Next, we will adjust the default extension from 90 minutes to 4 hours.
Lastly, we can look at customizing the extension time in the extension
flow or with a pre-emptive prompt next to the stop time.