Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Stop showing resources aftercoder create#2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedJun 8, 2022
edited
Loading

This change avoids a confusing UX where the workspace agent shows "connecting" after create has completed.

Fixes#1036


Output:

Select a template below to preview the provisionedinfrastructure:  This template has customizable parameters. Values can be  changed after create, but may have unintended side effects  (like data loss).var.docker_image  Which Docker image would you like to use for your workspace?  >  codercom/enterprise-base:ubuntuPlanning workspace...✔ Queued [15ms]✔ Setting up [500ms]✔ Detecting persistent resources [1431ms]✔ Cleaning Up [0ms]┌──────────────────────────────────────────────────────────┐│ Workspace Preview                                        │├──────────────────────────────────────────────────────────┤│ RESOURCE                    STATUS     ACCESS            │├──────────────────────────────────────────────────────────┤│ docker_container.workspace  ephemeral                    ││ └─ dev (linux, )                        coder ssh test2  │├──────────────────────────────────────────────────────────┤│ docker_volume.home_volume   ephemeral                    │└──────────────────────────────────────────────────────────┘> Confirm create? (yes/no)✔ Queued [136ms]✔ Setting up [6ms]⧗  Starting workspace  Terraform 1.1.9  coder_agent.dev: Plan to create  docker_volume.home_volume: Plan to create  docker_container.workspace[0]: Plan to create  Plan: 3 to add, 0 to change, 0 to destroy.  coder_agent.dev: Creating...  coder_agent.dev: Creation complete after 0s [id=a76f21f8-1fc8-4990-b498-70dd97da2563]  docker_volume.home_volume: Creating...  docker_volume.home_volume: Creation complete after 0s [id=coder-maf-test2-root]  docker_container.workspace[0]: Creating...  docker_container.workspace[0]: Creation complete after 1s [id=a9ac14a867d28bcace2fe1b3c2eb747dda33994b6a586b2e9ab30b18250a776e]  Apply complete! Resources: 3 added, 0 changed, 0 destroyed.  Outputs: 0✔ Starting workspace [2916ms]✔ Cleaning Up [-5ms]The test2 workspace has been created!

This change avoids a confusing UX where the workspace agent shows"connecting" after create has completed.Fixes#1036
@mafredrimafredri self-assigned thisJun 8, 2022
@mafredrimafredri requested review fromf0ssel,spikecurtis anda teamJune 8, 2022 09:59
@mafredrimafredri merged commit2621093 intomainJun 9, 2022
@mafredrimafredri deleted the mafredri/skip-showing-resources-after-coder-create branchJune 9, 2022 07:44
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@spikecurtisspikecurtisspikecurtis approved these changes

@kylecarbskylecarbskylecarbs approved these changes

@f0sself0sselAwaiting requested review from f0ssel

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Final output on workspace creation shows "connecting" forever - confusing UX
4 participants
@mafredri@johnstcn@spikecurtis@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp