- Notifications
You must be signed in to change notification settings - Fork928
feat: set $HOME for coder agent in aws-linux template#2150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Spike Curtis <spike@coder.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
still left is Digital Ocean.
I don't think it will be needed there, the agent is started via systemd so the env should be ok.
| @@ -101,7 +101,7 @@ Content-Transfer-Encoding: 7bit | |||
| Content-Disposition: attachment; filename="userdata.txt" | |||
| #!/bin/bash | |||
| sudo -E -u ubuntu sh -c '${coder_agent.dev.init_script}' | |||
| sudo -u ubuntu sh -c '${coder_agent.dev.init_script}' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We could consider using-H to ensure HOME is set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
man page says that -H might be a system default, and in ubuntu is seems to be the case. Feels like overkill
Signed-off-by: Spike Curtis <spike@coder.com>
Second PR for#1386 --- still left is Digital Ocean.
It's unclear to me why we used
-Ein the first place; it doesn't make sense to me to pass the environment vars from the startup script (presumably running as root) to the agent script. Perhaps just mistakenly thinking we needed variables from provisioner/terraform to get passed---but these get substituted by terraform before the script is set in the metadata.