- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: replace moby/moby namesgenerator with internal implementation#21377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
zedkipp wants to merge1 commit intomainChoose a base branch fromzedkipp/namesgenerator
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7ed462c to3b1a5a7CompareThe moby/moby/pkg/namesgenerator package has ~25k unique name combinations. Withthe retry parameter, which is awkwardly an integer that only differs in behaviorwhen the value is > 0, it only adds a single digit (0-9), giving ~250k totalpossibilities. It also uses the math/rand package internally with the default seedwhich is deterministically random. In parallel tests, this combination hasexperienced collisions.This replaces the external dependency with an internal implementation that uses amonotonically increasing atomic counter instead of random digits, guaranteeinguniqueness within a process. Names in tests continue to be truncated to 32 characters(including atomic counter suffix) to fit common name length limits.
3b1a5a7 toa37605cCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The moby/moby/pkg/namesgenerator package has ~25k unique name combinations. With the retry parameter, which is awkwardly an integer that only differs in behavior when the value is > 0, it only adds a single digit (0-9), giving ~250k total possibilities. It also uses the math/rand package internally with the default seed which is deterministically random. In parallel tests, this combination has experienced collisions.
This replaces the external dependency with an internal implementation that uses a monotonically increasing atomic counter instead of random digits, guaranteeing uniqueness within a process. Names continue to be truncated to 32 characters (including atomic counter suffix) to fit common name length limits for test purposes.