- Notifications
You must be signed in to change notification settings - Fork1.1k
feat(cli): add --no-build flag to state push for state-only updates#21374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
kacpersaw wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+146 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Adds a --no-build flag to 'coder state push' that updates the Terraformstate directly without triggering a workspace build. This enablesstate-only migrations, such as migrating Kubernetes resources fromdeprecated types to versioned types.Changes:- Add PUT /api/v2/workspacebuilds/{id}/state endpoint- Add UpdateWorkspaceBuildState SDK method- Add --no-build/-n flag to 'coder state push'- Add confirmation prompt with --yes/-y skip option- Add test for --no-build functionalityFixes#21336Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
--no-buildflag tocoder state pushthat updates the Terraform state directly without triggering a workspace build.Use Case
This enables state-only migrations, such as migrating Kubernetes resources from deprecated types (e.g.,
kubernetes_config_map) to versioned types (e.g.,kubernetes_config_map_v1):coder state pull my-workspace> state.jsonterraform initterraform state rm -state=state.json kubernetes_config_map.exampleterraform import -state=state.json kubernetes_config_map_v1.example default/examplecoder state push --no-build my-workspace state.jsonChanges
PUT /api/v2/workspacebuilds/{id}/stateendpoint to update state without triggering a buildUpdateWorkspaceBuildStateSDK method--no-build/-nflag tocoder state push--yes/-y) since this is a potentially dangerous operation--no-buildfunctionalityFixes#21336