- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: remove state information from apply#21373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
All state/plan info is cached on the provisioner duringa session.
| logsCh,closeLogs,err:=member.WorkspaceBuildLogsAfter(ctx,build.ID,0) | ||
| t.Cleanup(func() { | ||
| _=closeLogs.Close() | ||
| }) | ||
| forlog:=rangelogsCh { | ||
| assert.NotContains(t,log.Output,"The terraform plan does not exist, there is nothing to do") | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is what I used in combination withgit bisect to get here.
| // state is the provisioner state (if any) | ||
| bytesstate=6; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
note: this is just in the provisioner proto and not in the provisionerd proto, so this should mean we don't need to touch the version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We do not need to bump the version 👍
| apply:=applyComplete.Type.(*proto.Response_Apply) | ||
| require.NotEmpty(t,apply.Apply.State,"state exists") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
note: added during debugging but keeping around
Uh oh!
There was an error while loading.Please reload this page.
enterprise/coderd/workspaces_test.go Outdated
| logger:=slogtest.Make(t,&slogtest.Options{IgnoreErrors:false}) | ||
| dv:=coderdtest.DeploymentValues(t) | ||
| db,ps:=dbtestutil.NewDB(t) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: this was me debugging, we don't need this
61d7d29 intomainUh oh!
There was an error while loading.Please reload this page.
No description provided.