Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: Update docs manifest home page and icons#2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jsjoeio merged 7 commits intomainfrombq/fix-docs-2
Jun 9, 2022
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)June 7, 2022 17:01
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems fine, but there is this PR that fixed an issue:#1630

@BrunoQuaresma
Copy link
CollaboratorAuthor

@kylecarbs good catch. cc.:@bpmct@jsjoeio we need to move the README to the docs to make it available on the docs website. Maybe what we can do is replicate the READMEs? Thoughts?

@kylecarbs
Copy link
Member

Should we make a separate README for the docs? I feel like they shouldn't necessarily be the same, since the routing might be a bit different.

bpmct and jsjoeio reacted with thumbs up emoji

@bpmct
Copy link
Member

Agreed - I think the docs can have a separate readme. happy to help with this tomorrow. for now, we can just do the table of contents?

kylecarbs and jsjoeio reacted with thumbs up emoji

Copy link
Contributor

@jsjoeiojsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this looks great! I agree with changes suggested by@khorne3 and@bpmct so after that should be good to merge!

{
"title":"Quickstart",
"description":"Create your first template and workspace",
"icon":"<svg class=\"MuiSvgIcon-root jss172\" focusable=\"false\" viewBox=\"0 0 24 24\" aria-hidden=\"true\"><path d=\"M22.7 19l-9.1-9.1c.9-2.3.4-5-1.5-6.9-2-2-5-2.4-7.4-1.3L9 6 6 9 1.6 4.7C.4 7.1.9 10.1 2.9 12.1c1.9 1.9 4.6 2.4 6.9 1.5l9.1 9.1c.4.4 1 .4 1.4 0l2.3-2.3c.5-.4.5-1.1.1-1.4z\"></path></svg>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@BrunoQuaresma I didn't know what icon to use so I just copied another one. We can update before we make the site live

@jsjoeiojsjoeioenabled auto-merge (squash)June 9, 2022 18:28
@jsjoeiojsjoeio merged commitd04d527 intomainJun 9, 2022
@jsjoeiojsjoeio deleted the bq/fix-docs-2 branchJune 9, 2022 18:46
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* chore: Update docs manifest home page and icons* RRemove contributors* Update template icon* fixup: manifest.json changes* fix: add missing readme to root* fix: add readme to /docs with toc* fix: add quickstart to manifestCo-authored-by: Joe Previte <jjprevite@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@bpmctbpmctbpmct approved these changes

+2 more reviewers

@jsjoeiojsjoeiojsjoeio left review comments

@khorne3khorne3khorne3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BrunoQuaresma@kylecarbs@bpmct@jsjoeio@khorne3

[8]ページ先頭

©2009-2025 Movatter.jp