Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add --max-failures to coder exp scaletest create-workspaces#21315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/scaletest-create-max-failures
Dec 18, 2025

Conversation

@spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedDec 18, 2025
edited
Loading

Adds--max-failures flag tocoder exp scaletest create-workspaces so that we can tolerate a few failures without failing the command.

When running our scale test infra, we create Kubernetes Jobs to create the initial cluster workspaces, then we have load-generation jobs that depend on them. At high scale, it's kind of expected that some of the requests will fail: even with 99.9% success, you still expect one failure per 1000. It's useful to be able to carry on with the scale test anyway and proceed to traffic generation.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewDecember 18, 2025 05:20
@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedDec 18, 2025
edited
Loading

Merge activity

  • Dec 18, 7:21 AM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Dec 18, 7:21 AM UTC:@spikecurtis merged this pull request withGraphite.

@spikecurtisspikecurtis merged commitcac6d4c intomainDec 18, 2025
56 of 58 checks passed
@spikecurtisspikecurtis deleted the spike/scaletest-create-max-failures branchDecember 18, 2025 07:21
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees

@spikecurtisspikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spikecurtis@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp