- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: create Workspace sharing form component using workspace sharing hook#21276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:jaaydenh/autocomplete-component
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
in this context where the component is still only being used in one place, I'd prefer to leave it in the pages/ directory. modules/ should mostly be multi-purpose stuff.
| onSubmit={(event) => { | ||
| event.preventDefault(); | ||
| onSubmit(); | ||
| }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
could we use anaction here instead? (which I think handlesevent.preventDefault() for you)
Uh oh!
There was an error while loading.Please reload this page.
This PR separate the data retrieval for workspace sharing ACL into a custom hook and creates a separate form component. This is in preparation for reusing the workspace sharing form from a new share button on the workspace page.