- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: removecss from variouspages/Template.* pages#21267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
jakehwll wants to merge2 commits intojakehwll/mui-cssnuke-componentsChoose a base branch
base:jakehwll/mui-cssnuke-components
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
feat: removecss from variouspages/Template.* pages#21267
jakehwll wants to merge2 commits intojakehwll/mui-cssnuke-componentsfromjakehwll/mui-cssnuke-templates
+303 −880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This attempts to remove all of the MUI/
@emotionbasedcssprops. Moving onto thepages/Templatesfolders. This should serve to align ourselves better with Tailwind/shadcn and our goal to remove mui from the database.I've made attempts to ensure the
line-heightis consistent, however this isn't always in best-practice with Tailwind in some cases. Minor pixel shifts may happen. There are around 9 or so components living incomponents/I haven't updated yet as the logic was scarier to migrate away from MUI.Note
This pull-request is a fork-out of#21154 as I found it was getting too big to merge and hard to understand. Alongside this various components were being misrepresented in Chromatic (despite rendering fine in Storybook). I felt it better to make this a set of PRs.
Chromatic Link /Chromatic Tests
cssfrom variouscomponents/elementscssfrom variouspages/Template.*pages