- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: removecss from variouscomponents/ elements#21263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
| exportconstEnterprise:Story={ | ||
| args:{ | ||
| children:<EnterpriseBadge/>, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This lacked a story and therefore lacked coverage. I introduced this test here.
| exportconstDeprecated:Story={ | ||
| args:{ | ||
| children:<DeprecatedBadge/>, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ditto
This lacked a story and therefore lacked coverage. I introduced this test here.
| color:theme.roles.warning.text, | ||
| }), | ||
| }satisfiesRecord<string,Interpolation<Theme>>; | ||
| constbadgeClasses={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure if we want to do this as apart of this PR but this probably could be better served byclass-variance-authority.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This entire component had no tests, I've introduced some so we can catch any issues going-forward with MaterialUI being removed.
| <FormSection | ||
| classes={{ | ||
| root:"flex flex-col gap-4", | ||
| root:"flex flex-collg:flex-col gap-4 lg:gap-4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is necessary due to new breakpoints being in Tailwind now. I don't love it..
Uh oh!
There was an error while loading.Please reload this page.
This attempts to remove all of the MUI/
@emotionbasedcssprops. We've begun by doing this specifically in thecomponents/folder. This should serve to align ourselves better with Tailwind/shadcn and our goal to remove mui from the database.I've made attempts to ensure the
line-heightis consistent, however this isn't always in best-practice with Tailwind in some cases. Minor pixel shifts may happen. There are around 9 or so components living incomponents/I haven't updated yet as the logic was scarier to migrate away from MUI.Note
This pull-request is a fork-out of#21154 as I found it was getting too big to merge and hard to understand. Alongside this various components were being misrepresented in Chromatic (despite rendering fine in Storybook). I felt it better to make this a set of PRs.
@codex