- Notifications
You must be signed in to change notification settings - Fork1.1k
perf: optimize postgres on macOS/Windows for CI, remove ramdisk#21226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
mafredri wants to merge6 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+186 −140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5ffcb9e tob00519eComparePreviously we used ramdisk for embedded postgres on macOS and Windowsto improve test performance. This wastes memory since data ends upcached twice: once in the ramdisk and again in postgres's own buffers.Instead, we give postgres more memory and tune it more aggressively:- Increase shared_buffers to 2GB, effective_cache_size to 4GB- Minimal WAL level, infrequent checkpoints- Disable autovacuum, JIT, logging, stats tracking- OS-specific I/O settingsThis gives postgres more memory to work with while simplifying CI setup.
b00519e to4cb8dafCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we used ramdisk for embedded postgres on macOS and Windows
to improve test performance. This wastes memory since data ends up
cached twice: once in the ramdisk and again in postgres's own buffers.
Instead, we give postgres more memory and tune it more aggressively:
This gives postgres more memory to work with while simplifying CI setup.