Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add workspace sharing indicator#21222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jaaydenh wants to merge2 commits intogeokat/internal-858-sharing-info-in-workspaces-response
base:geokat/internal-858-sharing-info-in-workspaces-response
Choose a base branch
Loading
fromjaaydenh/sharing-indicator

Conversation

@jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedDec 11, 2025•
edited
Loading

Screenshot 2025-12-11 at 13 10 01

@jaaydenhjaaydenh self-assigned thisDec 11, 2025
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

code looks good, but design wise...

  • in the original design, the settings link was a button
  • I feel like things look a little vertically cramped. could we add just a bit more gap/padding in between?
Image

@geokatgeokatforce-pushed thegeokat/internal-858-sharing-info-in-workspaces-response branch from629e5b4 to73a619cCompareDecember 12, 2025 15:16
@jaaydenh
Copy link
ContributorAuthor

@aslilac I was referencing the new designs created by christin,https://www.figma.com/design/CNr6qGcPhbq3Qut6rENz6i/Shared-Workspaces?node-id=168-3958&t=Ga6q3znU5CzyVLZO-1

Good catch on the settings button, I changed this because of the designs but I actually think the button is the correct UI here.

Screenshot 2025-12-12 at 15 10 55

@geokatgeokatforce-pushed thegeokat/internal-858-sharing-info-in-workspaces-response branch from73a619c toa50b597CompareDecember 12, 2025 16:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaaydenh@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp