- Notifications
You must be signed in to change notification settings - Fork1.1k
feat!: support PKCE in the oauth2 client's auth/exchange flow#21215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Emyrk wants to merge18 commits intomainChoose a base branch fromstevenmasley/oauth_pkce
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+479 −175
Open
Changes from1 commit
Commits
Show all changes
18 commits Select commitHold shift + click to select a range
08f52e9 feat: oauth2 client to use pkce in auth/exchange flow
Emyrk40283ea force pkce
Emyrk5eb6e9f chore: pkce defaults
Emyrk53fc864 frontend test
Emyrkead92c8 chore: sane defaults and make gen
Emyrk0be0bb2 make some tests use pkce
Emyrk303ea30 fmt
Emyrk7af6c3a fix tests
Emyrk7f11ab7 make gen
Emyrk65b08c8 fix tests
Emyrkc6b3b24 fix tests
Emyrk37aa4c0 PR feedback
Emyrk263b925 rename cookie from challenge to verifier
Emyrk3e78053 Add some comments
Emyrkef3a3d3 make gen
Emyrk82fdc0f docs: added docs to external auth page
Emyrka753ff4 remove oidc from docs, since it is auto
Emyrk675b528 PR feedback
EmyrkFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
force pkce
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit40283ea3835472b262f2fefa3cc84a725f2d4266
There are no files selected for viewing
17 changes: 12 additions & 5 deletionscoderd/httpmw/oauth2.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.