Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(cli): display template version name in push output#21192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
matifali wants to merge3 commits intomain
base:main
Choose a base branch
Loading
fromfix/issue-21111-display-version-name
Open
Changes from1 commit
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
fix(cli): update test expectation for new version output format
The test was expecting the old output format "Updated version at" butthe new format is "Updated version {name} at". Updated the test tomatch the beginning of the output string.
  • Loading branch information
@matifali
matifali committedDec 9, 2025
commitcb2d0add267af2344c78c0b23ca899ce1494a254
2 changes: 1 addition & 1 deletioncli/templatepush_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,7 +106,7 @@ func TestTemplatePush(t *testing.T) {
inv = inv.WithContext(ctx)
w := clitest.StartWithWaiter(t, inv)

pty.ExpectNoMatchBefore(ctx, "Template message is longer than 72 characters", "Updated version at")
pty.ExpectNoMatchBefore(ctx, "Template message is longer than 72 characters", "Updated version")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we make sure that the template version matches the one exposed via API, and match the whole phraseUpdated version XYZ at?

EDIT:
I guess we could match the timestamp too, but it isn't crucial.


w.RequireSuccess()

Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp