Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(site): add icons for .sh, .json, and .y[a]ml files in template editor#21171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
phorcys420 merged 4 commits intomainfromfix-rename-dialog-state
Dec 10, 2025

Conversation

@matifali
Copy link
Member

@matifalimatifali commentedDec 8, 2025
edited
Loading

Added specific icons for common file types in the template file tree:

  • .sh files: TerminalIcon (terminal/shell scripts)
  • .json files: BracesIcon (JSON data files)
  • .yaml/.yml files: FileCodeIcon (YAML configuration files)
image

These icons help users quickly identify file types at a glance in the template editor.

Added specific icons for common file types in the template file tree:- .sh files: TerminalIcon (terminal/shell scripts)- .json files: BracesIcon (JSON data files)- .yaml/.yml files: FileCodeIcon (YAML configuration files)These icons help users quickly identify file types at a glance.
@matifalimatifaliforce-pushed thefix-rename-dialog-state branch fromeeb5a97 toc0cd338CompareDecember 8, 2025 19:00
@matifalimatifali changed the titlefix(site): sync RenameFileDialog state when filename prop changesfeat(site): add icons for .sh, .json, and .yaml files in template editorDec 8, 2025
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

This PR enhances the template file tree UI by adding distinctive icons for three common file types (.sh, .json, .yaml/.yml) that previously had no specific visual representation. The implementation uses lucide-react icons (TerminalIcon, BracesIcon, FileCodeIcon) following the existing conditional logic pattern based on file extensions.

Key Changes:

  • Added file type detection for .sh, .json, and .yaml/.yml files
  • Imported three new icons from lucide-react library
  • Extended icon assignment logic in the buildTreeItems function

💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.

Updated the main example story to include files with the new icons:- Shell scripts (.sh) - terminal icon- JSON files (.json) - braces icon- YAML files (.yml) - file code icon- Markdown (.md) and Dockerfile iconsThis shows all icon types in a single realistic file tree example.
@matifalimatifaliforce-pushed thefix-rename-dialog-state branch from333f052 to4dfbbfeCompareDecember 8, 2025 19:22
@matifalimatifali changed the titlefeat(site): add icons for .sh, .json, and .yaml files in template editorfeat(site): add icons for .sh, .json, and .y[a]ml files in template editorDec 10, 2025
@phorcys420phorcys420 merged commited3bb76 intomainDec 10, 2025
29 of 31 checks passed
@phorcys420phorcys420 deleted the fix-rename-dialog-state branchDecember 10, 2025 20:19
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@geokatgeokatgeokat left review comments

Copilot code reviewCopilotCopilot left review comments

@phorcys420phorcys420phorcys420 approved these changes

Assignees

@matifalimatifali

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matifali@geokat@phorcys420

[8]ページ先頭

©2009-2025 Movatter.jp