- Notifications
You must be signed in to change notification settings - Fork928
fix: Update routing for workspace schedule#2113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There were a few problems that weren't caught by tests in the other PR. I should have been more thorough to catch redirects, and now I've gone through the whole app to verify there aren't any paths missing! |
d48687b to3beddf3CompareThis was broken as part of#2101. It was a silly mistake,but unfortunate our tests didn't catch it.This is a rare change so unlikely to occur again, so I won'tmake an issue adding tests.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Frontend looks good
Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>
Closes#2124 |
* fix: Update routing for workspace scheduleThis was broken as part of#2101. It was a silly mistake,but unfortunate our tests didn't catch it.This is a rare change so unlikely to occur again, so I won'tmake an issue adding tests.* Update site/src/pages/WorkspaceSchedulePage/WorkspaceSchedulePage.tsxCo-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>Co-authored-by: Presley Pizzo <1290996+presleyp@users.noreply.github.com>
This was broken as part of#2101. It was a silly mistake,
but unfortunate our tests didn't catch it.
This is a rare change so unlikely to occur again, so I won't
make an issue adding tests.