NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.6k

feat: add serviceAccount.labels for custom service account labels on helm chart#21048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

rowansmithau wants to merge1 commit intomain

base:main

Choose a base branch

fromrowansmithau/feat/helm_service_account_labels

Open

feat: add serviceAccount.labels for custom service account labels on helm chart#21048

rowansmithau wants to merge1 commit intomainfromrowansmithau/feat/helm_service_account_labels

+9 −0

Conversation

Copy link

Contributor

rowansmithau commentedDec 2, 2025

closes#20541

addscoder.serviceAccount.labels var to support custom labels being added to the SA.

Current chart:

➜  helm-service-account-labels git:(rowansmithau/feat/helm_service_account_labels) helm template coder coder-v2/coder --set coder.image.tag=latest --set coder.serviceAccount.labels.mux=isnice | egrep -A13 '^kind: ServiceAccount$'kind: ServiceAccountmetadata:  annotations: {}  labels:    app.kubernetes.io/instance: coder    app.kubernetes.io/managed-by: Helm    app.kubernetes.io/name: coder    app.kubernetes.io/part-of: coder    app.kubernetes.io/version: 2.28.3    helm.sh/chart: coder-2.28.3  name: coder  namespace: default---# Source: coder/templates/rbac.yaml

With this PR:

➜  helm-service-account-labels git:(rowansmithau/feat/helm_service_account_labels) helm template coder helm/coder --set coder.image.tag=latest --set coder.serviceAccount.labels.mux=isnice | egrep -A13 '^kind: ServiceAccount$'kind: ServiceAccountmetadata:  annotations: {}  labels:    app.kubernetes.io/instance: coder    app.kubernetes.io/managed-by: Helm    app.kubernetes.io/name: coder    app.kubernetes.io/part-of: coder    app.kubernetes.io/version: 0.1.0    helm.sh/chart: coder-0.1.0    mux: isnice  name: coder  namespace: default---

A test withdisableCreate=true still correctly shows no SA created:

➜  helm-service-account-labels git:(rowansmithau/feat/helm_service_account_labels) helm template coder helm/coder --set coder.image.tag=latest --set coder.serviceAccount.labels.mux=isnice --set coder.serviceAccount.disableCreate=true | egrep '^kind: ServiceAccount$'