Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Show correct 'no results' message on workspace filters#2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
f0ssel merged 7 commits intomainfromf0ssel/fix-no-results
Jun 7, 2022

Conversation

f0ssel
Copy link
Contributor

Fixes#2042.

Open to suggestions on what to display here, right now there's currently no description text.

chrome_99vpCmpq2c

@f0sself0ssel requested a review froma team as acode ownerJune 6, 2022 20:47
</TableCell>
</TableRow>
<>
{query === "owner:me" || query === "" ? (
Copy link
Contributor

@greyscaledgreyscaledJun 6, 2022•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggestion: I'd make these constants and re-use those constants here and in the form menu. Maybe inutils/workspaces.ts

f0ssel reacted with thumbs up emoji
@greyscaled
Copy link
Contributor

greyscaled commentedJun 6, 2022•
edited
Loading

Suggestion: Can we adjust the storybook so that there's a case for each the paths?

See what I mean here:https://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=629e690bcbc710004ad776c9

f0ssel reacted with thumbs up emoji

@f0ssel
Copy link
ContributorAuthor

Will need some guidance on the story stuff, I'm looking athttps://github.com/coder/coder/blob/main/site/src/pages/WorkspacesPage/WorkspacesPageView.stories.tsx and I'm pretty lost on how to add my query stuff.

@presleyp
Copy link
Contributor

@f0ssel happy to get on discord sometime today and figure out the storybook stuff

f0ssel reacted with thumbs up emoji

@BrunoQuaresma
Copy link
Collaborator

Probably some of these conflicts are related to this PR#2097 basically what I made to cause this was to move all the logic from WorkspacePage to the WorkspacePageView so we could easily test that using Storybook. Please, let me know if you need help to solve the conflict.

f0ssel reacted with thumbs up emoji

@f0sself0sselforce-pushed thef0ssel/fix-no-results branch from2b69691 tob0d1bb0CompareJune 7, 2022 16:20
@f0sself0ssel merged commit7258d6a intomainJun 7, 2022
@f0sself0ssel deleted the f0ssel/fix-no-results branchJune 7, 2022 18:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty workspace search results should clarify that there are no results
4 participants
@f0ssel@greyscaled@presleyp@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp