- Notifications
You must be signed in to change notification settings - Fork1.1k
feat(coderd/database/dbpurge): add retention for connection logs#21022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mafredri wants to merge4 commits intomafredri/feat-coderd-db-retention-policyChoose a base branch
base:mafredri/feat-coderd-db-retention-policy
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
feat(coderd/database/dbpurge): add retention for connection logs#21022
mafredri wants to merge4 commits intomafredri/feat-coderd-db-retention-policyfrommafredri/feat-coderd-db-retention-policy-2
+214 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
c067a63 to661866dCompareb8a4bdb to0fb3b51Compare This was referencedDec 1, 2025
724b589 to782f1f7Compareethanndickson approved these changesDec 2, 2025
Member
ethanndickson left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nice! I'm glad we're doing this.
Uh oh!
There was an error while loading.Please reload this page.
b34ee61 tod5062e2CompareConnection logs retention is now explicit - it's enabled when--connection-logs-retention is set to a non-zero duration, anddisabled when set to 0. No fallback to global retention.
782f1f7 to039afdbCompareUse :execrows instead of :one to simplify the query by removing theextra CTE wrapper. This lets PostgreSQL return the row count directlyvia RowsAffected() instead of requiring an explicit COUNT(*) scan.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Add
DeleteOldConnectionLogsquery and integrate it into thedbpurgeroutine. Retention is controlled by
--retention-connection-logsflag,falling back to
--retention-globalwhen not set. Disabled (0) bydefault.
Depends on#21021
Updates#20743
PR Stack
workspace_agent_logs