- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: disable autoupgrade of GH Actions version upgrades#21019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
…ot automerged if it's a GitHub Action ecosystem
matifali left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
jdomeracki-coder commentedDec 1, 2025
Gentleman, that was a missclick |
jdomeracki-coder commentedDec 1, 2025
Great example of how easy it is to introduce security hotspots info[template-injection]: code injection via template expansion --> ./.github/workflows/dependabot.yaml:50:21|49| run:|| --- info: this run block50|if ["${{ steps.metadata.outputs.package-ecosystem }}"="github-actions" ];then| ---------------------------------------- info: may expand into attacker-controllable code| = note: audit confidence → Low = note: this finding has an auto-fix https://github.com/coder/coder/actions/runs/19821110267/job/56783487704?pr=21019#step:12:114 Even though in this instance it's extremely unlikely that the value would be controlled by an attacker, Zizmor did a great job of catching this |
jdomeracki-coder commentedDec 1, 2025
Need to verify why the lint job keeps on failing, doesn't seem to be security related: |
cbb0952 intomainUh oh!
There was an error while loading.Please reload this page.
Addresses
coder/internal#1166