Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test: use toHaveValue() to avoid flaky parameter verification#20990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromfix-workspace-parameter-test-flake
Dec 1, 2025

Conversation

@ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedDec 1, 2025
edited
Loading

Problem

The testcreate workspace with default and required parameters was flaky becauseverifyParameters insite/e2e/helpers.ts didn't wait for input values to be populated before asserting.

After PR#20710 removed classic parameters, the form now uses dynamic parameters loaded asynchronously via WebSocket. The input field can be visible before its value is populated.

Closescoder/internal#1154

Fix

Replace immediate read + assertion:

constvalue=awaitparameterField.inputValue();expect(value).toEqual(buildParameter.value);

With Playwright's auto-retrying assertion:

awaitexpect(parameterField).toHaveValue(buildParameter.value);

FromPlaywright docs forinputValue():

NOTE If you need to assert input value, preferexpect(locator).toHaveValue(value[, options]) to avoid flakiness. See assertions guide for more details.


This PR was fully generated bymux, and reviewed by a human.

Replace inputValue() + expect() with toHaveValue() assertion inverifyParameters helper to prevent race conditions when checkingdynamically loaded workspace parameters.
@ethanndicksonethanndickson changed the titlefix(e2e): use toHaveValue() to avoid flaky parameter verificationtest: use toHaveValue() to avoid flaky parameter verificationDec 1, 2025
Copy link
Contributor

@jakehwlljakehwll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sounds reasonable to me

@ethanndicksonethanndickson merged commit782a105 intomainDec 1, 2025
37 checks passed
@ethanndicksonethanndickson deleted the fix-workspace-parameter-test-flake branchDecember 1, 2025 02:46
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jakehwlljakehwlljakehwll approved these changes

@aslilacaslilacAwaiting requested review from aslilac

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flake: e2e create workspace with default and required parameters

3 participants

@ethanndickson@jakehwll

[8]ページ先頭

©2009-2025 Movatter.jp