- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: add notification warning alert to Tasks page (#20900)#20981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ssncferreira wants to merge1 commit intorelease/2.29Choose a base branch fromssncferreira/2.29-backport-20900
base:release/2.29
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Users may not realize that task notifications are disabled by default.To improve awareness, we show a warning alert on the Tasks page when alltask notifications are disabled.**Alert visibility logic:**- Shows when **all** task notification templates (Task Working, TaskIdle, Task Completed, Task Failed) are disabled- Can be dismissed by the user, which stores the dismissal in the userpreferences API- If the user later enables any task notification in Account Settings,the dismissal state is cleared so the alert will show again if theydisable all notifications in the future<img width="2980" height="1588" alt="Screenshot 2025-11-25 at 17 48 17"src="https://github.com/user-attachments/assets/316bf097-d9d2-4489-bc16-2987ba45f45c"/>- Added a warning alert to the Tasks page when all task notificationsare disabled- Introduced new `/users/{user}/preferences` endpoint to manage userpreferences (stored in `user_configs` table)- Alert is dismissible and stores the dismissal state via the new userpreferences API endpoint- Enabling any task notification in Account Settings clears thedismissal state via the preferences API- Added comprehensive Storybook stories for both TasksPage andNotificationsPage to test all alert visibility states and interactionsCloses:coder/internal#1089(cherry picked from commitf8d9a80)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to PR:#20900
(cherry picked from commitf8d9a80)