Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add notification warning alert to Tasks page (#20900)#20981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ssncferreira wants to merge1 commit intorelease/2.29
base:release/2.29
Choose a base branch
Loading
fromssncferreira/2.29-backport-20900

Conversation

@ssncferreira
Copy link
Contributor

Related to PR:#20900

(cherry picked from commitf8d9a80)

Users may not realize that task notifications are disabled by default.To improve awareness, we show a warning alert on the Tasks page when alltask notifications are disabled.**Alert visibility logic:**- Shows when **all** task notification templates (Task Working, TaskIdle, Task Completed, Task Failed) are disabled- Can be dismissed by the user, which stores the dismissal in the userpreferences API- If the user later enables any task notification in Account Settings,the dismissal state is cleared so the alert will show again if theydisable all notifications in the future<img width="2980" height="1588" alt="Screenshot 2025-11-25 at 17 48 17"src="https://github.com/user-attachments/assets/316bf097-d9d2-4489-bc16-2987ba45f45c"/>- Added a warning alert to the Tasks page when all task notificationsare disabled- Introduced new `/users/{user}/preferences` endpoint to manage userpreferences (stored in `user_configs` table)- Alert is dismissible and stores the dismissal state via the new userpreferences API endpoint- Enabling any task notification in Account Settings clears thedismissal state via the preferences API- Added comprehensive Storybook stories for both TasksPage andNotificationsPage to test all alert visibility states and interactionsCloses:coder/internal#1089(cherry picked from commitf8d9a80)
@ssncferreirassncferreira added the cherry-pick/v2.29Needs to be cherry-picked to the 2.29 release branch labelNov 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@david-fraleydavid-fraleyAwaiting requested review from david-fraley

At least 1 approving review is required to merge this pull request.

Assignees

@ssncferreirassncferreira

Labels

cherry-pick/v2.29Needs to be cherry-picked to the 2.29 release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ssncferreira

[8]ページ先頭

©2009-2025 Movatter.jp