- Notifications
You must be signed in to change notification settings - Fork1.1k
test: fix TestDescCacheTimestampUpdate flake#20975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ethanndickson wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+30 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
TestDescCacheTimestampUpdate was flaky on Windows because time.Now()has ~15.6ms resolution, causing consecutive calls to return identicaltimestamps.Changes:- Add quartz.Clock field to MetricsAggregator with options pattern- Replace all time.Now() calls with clock.Now()- Use mock clock in test with explicit time advancement
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Problem
TestDescCacheTimestampUpdatewas flaky on Windows CI becausetime.Now()has ~15.6ms resolution, causing consecutive calls to return identical timestamps.Solution
Inject
quartz.ClockintoMetricsAggregatorusing an options pattern, making the test deterministic by using a mock clock with explicit time advancement.Changes
clock quartz.Clockfield toMetricsAggregatorstructWithClock()option for dependency injectiontime.Now()calls withma.clock.Now()mClock.Advance(time.Second)This PR was fully generated by
muxusing Claude Opus 4.5, and reviewed by me.Closescoder/internal#1146