Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add helpful tooltips for the key features#2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 7 commits intomainfrombq/add-page-header-and-tooltips
Jun 7, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedJun 6, 2022•
edited
Loading

  • Add PageHeader component
  • Add HelpTooltip component

Closes#1640

Screen Shot 2022-06-06 at 15 11 58

Screen Shot 2022-06-06 at 15 11 45

@BrunoQuaresmaBrunoQuaresma self-assigned thisJun 6, 2022
@BrunoQuaresmaBrunoQuaresma requested a review froma team as acode ownerJune 6, 2022 18:12
@BrunoQuaresmaBrunoQuaresma changed the titleBq/add page header and tooltipsfeat: Add helpful tooltips for the key featuresJun 6, 2022
@tjcran
Copy link

@BrunoQuaresma the resource tooltip looks good to me! The template tooltip, I think it's better if we remove the second sentence and just end with the word "terraform". What do you think?

BrunoQuaresma reacted with thumbs up emoji

Comment on lines +24 to +25
<HelpTooltipLink href="https://github.com/coder/coder/">Creating a template</HelpTooltipLink>
<HelpTooltipLink href="https://github.com/coder/coder/">Updating a template</HelpTooltipLink>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe just one link to the templates doc for now labeled "managing templates"?

https://github.com/coder/coder/blob/main/docs/templates.md#templates

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ahh, this one is just a sample. I'm already using this link for the templates:

 <HelpTooltipLink href="https://github.com/coder/coder/blob/main/docs/templates.md#manage-templates">  Manage templates</HelpTooltipLink>

Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we could use someLanguage objects for the tooltip copy. I understand the tooltip copy is still be reviewed but once that's refined, this looks great from a FE perspective!

BrunoQuaresma reacted with thumbs up emoji
@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)June 7, 2022 13:35
@BrunoQuaresmaBrunoQuaresma merged commiteedd293 intomainJun 7, 2022
@BrunoQuaresmaBrunoQuaresma deleted the bq/add-page-header-and-tooltips branchJune 7, 2022 13:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bpmctbpmctbpmct left review comments

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance: There are no definitions in the UI yet for key features
4 participants
@BrunoQuaresma@tjcran@Kira-Pilot@bpmct
[8]ページ先頭
©2009-2025 Movatter.jp