- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: show task display name in task topbar#20957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| </TooltipProvider> | ||
| <h1className="m-0 pl-2 text-base font-medium truncate">{task.name}</h1> | ||
| <h1className="m-0 pl-2 text-base font-medium max-w-[520px] truncate"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just defaulting to the same value as in theTasks list view. In the backend, we also always guarantee that the display name is only 64 characters, which should not reach this maximum.
DanielleMaywood commentedNov 27, 2025
When given a long task name, it causes these two buttons to touch  |
mafredri left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍🏻
ssncferreira commentedNov 27, 2025
Nice catch 👀 Addressed in:2b64a2e with some styling changes, but not sure if it is the best way |
Uh oh!
There was an error while loading.Please reload this page.
| </TooltipProvider> | ||
| <h1className="m-0 pl-2 text-base font-medium truncate">{task.name}</h1> | ||
| <h1className="m-0 pl-2 text-base font-medium max-w-[520px] truncate"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| <h1className="m-0 pl-2 text-base font-medium max-w-[520px] truncate"> | |
| <h1className="m-0 pl-2 text-base font-medium max-w-[64ch] truncate"> |
We talked about this during our chat, unsure if we do this pattern elsewhere but it might look less magic to someone reading in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As discussed on Slack, it looks like this doesn’t exactly meet the 64-characters, which leads to the page width expanding, which isn’t ideal 🙁
21efebe intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Description
Update task topbar in task page to show display name, instead of task name.
Follow-up PR:#20918
Related to internal slack thread:https://codercom.slack.com/archives/C0992H8HGCS/p1764086497375829