- Notifications
You must be signed in to change notification settings - Fork1.1k
fix(cli): remove defaulting to keyring when --global-config set (cherry-pick)#20953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
zedkipp wants to merge1 commit intorelease/2.29Choose a base branch
base:release/2.29
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+38 −20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This fixes a regression that caused the VS code extension to be unableto authenticate after making keyring usage on by default. This isbecause the VS code extension assumes the CLI will always use thesession token stored on disk, specifically in the directory specified by--global-config.This fix makes keyring usage enabled when the --global-config directoryis not set. This is a bit wonky but necessary to allow the extension tocontinue working without modification and without backwards compatconcerns. In the future we should modify these extensions to eitheraccess the credential in the keyring (like Coder Desktop) or some otherapproach that doesn't rely on the session token being stored on disk.Tests:`coder login dev.coder.com` -> token stored in keyring`coder login --global-config=/tmp/ dev.coder.com` -> token stored in`/tmp/session`(cherry picked from commitbbf7b13)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression that caused the VS code extension to be unable to authenticate after making keyring usage on by default. This is because the VS code extension assumes the CLI will always use the session token stored on disk, specifically in the directory specified by --global-config.
This fix makes keyring usage enabled when the --global-config directory is not set. This is a bit wonky but necessary to allow the extension to continue working without modification and without backwards compat concerns. In the future we should modify these extensions to either access the credential in the keyring (like Coder Desktop) or some other approach that doesn't rely on the session token being stored on disk.
Tests:
coder login dev.coder.com-> token stored in keyringcoder login --global-config=/tmp/ dev.coder.com-> token stored in/tmp/session(cherry picked from commitbbf7b13)