Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: replace spyOn with queries parameter in TasksPage stories#20948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
mafredri wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromfix-spyon-usage
Draft
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
191 changes: 129 additions & 62 deletionssite/src/pages/TasksPage/TasksPage.stories.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ import { API } from "api/api";
import { MockUsers } from "pages/UsersPage/storybookData/users";
import { expect, spyOn, userEvent, waitFor, within } from "storybook/test";
import { getTemplatesQueryKey } from "../../api/queries/templates";
import { usersKey } from "../../api/queries/users";
import TasksPage from "./TasksPage";

const meta: Meta<typeof TasksPage> = {
Expand All@@ -23,23 +24,35 @@ const meta: Meta<typeof TasksPage> = {
permissions: {
viewDeploymentConfig: true,
},
},
beforeEach: () => {
spyOn(API, "getTemplateVersionExternalAuth").mockResolvedValue([]);
spyOn(API, "getTemplateVersionPresets").mockResolvedValue(null);
spyOn(API, "getUsers").mockResolvedValue({
users: MockUsers,
count: MockUsers.length,
});
spyOn(API, "getTemplates").mockResolvedValue([
MockTemplate,
queries: [
{
key: ["template_version_external_auth"],
data: [],
},
{
key: ["template_version_presets"],
data: null,
},
{
key: usersKey({ q: "" }),
data: {
users: MockUsers,
count: MockUsers.length,
},
},
{
...MockTemplate,
id: "test-template-2",
name: "template 2",
display_name: "Template 2",
key: getTemplatesQueryKey({ q: "has-ai-task:true" }),
data: [
MockTemplate,
{
...MockTemplate,
id: "test-template-2",
name: "template 2",
display_name: "Template 2",
},
],
},
]);
],
},
};

Expand DownExpand Up@@ -81,8 +94,15 @@ export const LoadingTemplatesError: Story = {
};

export const LoadingTasks: Story = {
parameters: {
queries: [
{
key: getTemplatesQueryKey({ q: "has-ai-task:true" }),
data: [MockTemplate],
},
],
},
beforeEach: () => {
spyOn(API, "getTemplates").mockResolvedValue([MockTemplate]);
spyOn(API, "getTasks").mockImplementation(
() => new Promise(() => 1000 * 60 * 60),
);
Expand All@@ -99,8 +119,15 @@ export const LoadingTasks: Story = {
};

export const LoadingTasksError: Story = {
parameters: {
queries: [
{
key: getTemplatesQueryKey({ q: "has-ai-task:true" }),
data: [MockTemplate],
},
],
},
beforeEach: () => {
spyOn(API, "getTemplates").mockResolvedValue([MockTemplate]);
spyOn(API, "getTasks").mockRejectedValue(
mockApiError({
message: "Failed to load tasks",
Expand All@@ -110,16 +137,32 @@ export const LoadingTasksError: Story = {
};

export const EmptyTasks: Story = {
beforeEach: () => {
spyOn(API, "getTemplates").mockResolvedValue([MockTemplate]);
spyOn(API, "getTasks").mockResolvedValue([]);
parameters: {
queries: [
{
key: getTemplatesQueryKey({ q: "has-ai-task:true" }),
data: [MockTemplate],
},
{
key: ["tasks", { owner: MockUserOwner.username }],
data: [],
},
],
},
};

export const LoadedTasks: Story = {
beforeEach: () => {
spyOn(API, "getTemplates").mockResolvedValue([MockTemplate]);
spyOn(API, "getTasks").mockResolvedValue(MockTasks);
parameters: {
queries: [
{
key: getTemplatesQueryKey({ q: "has-ai-task:true" }),
data: [MockTemplate],
},
{
key: ["tasks", { owner: MockUserOwner.username }],
data: MockTasks,
},
],
},
};

Expand All@@ -139,42 +182,52 @@ export const DisplayName: Story = {
};

export const LoadedTasksWaitingForInputTab: Story = {
beforeEach: () => {
const [firstTask, ...otherTasks] = MockTasks;
spyOn(API, "getTemplates").mockResolvedValue([MockTemplate]);
spyOn(API, "getTasks").mockResolvedValue([
{
...firstTask,
id: "active-idle-task",
display_name: "Active Idle Task",
status: "active",
current_state: {
...firstTask.current_state,
state: "idle",
},
},
parameters: {
queries: [
{
...firstTask,
id: "paused-idle-task",
display_name: "Paused Idle Task",
status: "paused",
current_state: {
...firstTask.current_state,
state: "idle",
},
key: getTemplatesQueryKey({ q: "has-ai-task:true" }),
data: [MockTemplate],
},
{
...firstTask,
id: "error-idle-task",
display_name: "Error Idle Task",
status: "error",
current_state: {
...firstTask.current_state,
state: "idle",
},
key: ["tasks", { owner: MockUserOwner.username }],
data: (() => {
const [firstTask, ...otherTasks] = MockTasks;
return [
{
...firstTask,
id: "active-idle-task",
display_name: "Active Idle Task",
status: "active",
current_state: {
...firstTask.current_state,
state: "idle",
},
},
{
...firstTask,
id: "paused-idle-task",
display_name: "Paused Idle Task",
status: "paused",
current_state: {
...firstTask.current_state,
state: "idle",
},
},
{
...firstTask,
id: "error-idle-task",
display_name: "Error Idle Task",
status: "error",
current_state: {
...firstTask.current_state,
state: "idle",
},
},
...otherTasks,
];
})(),
},
...otherTasks,
]);
],
},
play: async ({ canvasElement, step }) => {
const canvas = within(canvasElement);
Expand DownExpand Up@@ -210,10 +263,16 @@ export const NonAdmin: Story = {
permissions: {
viewDeploymentConfig: false,
},
},
beforeEach: () => {
spyOn(API, "getTemplates").mockResolvedValue([MockTemplate]);
spyOn(API, "getTasks").mockResolvedValue(MockTasks);
queries: [
{
key: getTemplatesQueryKey({ q: "has-ai-task:true" }),
data: [MockTemplate],
},
{
key: ["tasks", { owner: MockUserOwner.username }],
data: MockTasks,
},
],
},
play: async ({ canvasElement, step }) => {
const canvas = within(canvasElement);
Expand All@@ -228,9 +287,17 @@ export const NonAdmin: Story = {
};

export const OpenDeleteDialog: Story = {
beforeEach: () => {
spyOn(API, "getTemplates").mockResolvedValue([MockTemplate]);
spyOn(API, "getTasks").mockResolvedValue(MockTasks);
parameters: {
queries: [
{
key: getTemplatesQueryKey({ q: "has-ai-task:true" }),
data: [MockTemplate],
},
{
key: ["tasks", { owner: MockUserOwner.username }],
data: MockTasks,
},
],
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp