- Notifications
You must be signed in to change notification settings - Fork1.1k
refactor(site): swap emotion for tailwind in workspace batch delete dialogue#20946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mafredri wants to merge2 commits intomainChoose a base branch frommafredri/refactor-site-clean-up-workspaces-bulk-delete
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+36 −107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedNov 26, 2025
mafredri added a commit that referenced this pull requestNov 26, 2025
Add comprehensive documentation for active frontend pattern migrationsdiscovered through analysis of 200+ git commits touching site/ files:Core Migrations:- Emotion → Tailwind CSS (strict 'no new emotion' policy)- MUI Components → Custom/Radix/shadcn (Tooltips, Tables, Buttons)- MUI Icons → lucide-react with specific icon mappings- spyOn → queries parameter for GET endpoint mocks in Storybook- localStorage → user_configs table for user preferencesNew Documentation:- Icon migration mappings (BusinessIcon→Building2Icon, etc.)- Radix component prop naming conventions (placement→side)- cn() utility usage for conditional className merging- Chromatic testing best practices (prefer snapshots over assertions)Includes concrete before/after examples and migration patterns to guidedevelopers away from deprecated approaches toward current best practices.Analysis based on PRs:#20948,#20946,#20938,#20905,#20900,#20869,#20849,#20808,#20530,#20479,#20261,#20201,#20200,#20193,#20318---🤖 This change was written by Claude Sonnet 4.5 Thinking using mux and reviewed by a human 🏂
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
References#20905