- Notifications
You must be signed in to change notification settings - Fork1.1k
perf: add index to improve the GetWorkspaceAgentByInstanceID query performance#20936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
github-actionsbot commentedNov 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All contributors have signed the CLA ✍️ ✅ |
mykyta-protsenko commentedNov 25, 2025
I have read the CLA Document and I hereby sign the CLA |
mykyta-protsenko commentedNov 25, 2025
recheck |
Signed-off-by: Danny Kopping <danny@coder.com>
dannykopping left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank youvery much for this@mykyta-protsenko!
c87c33f intocoder:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Context
GetWorkspaceAgentByInstanceID has a suboptimal plan. Even though it is designed to fetch a small subset of records, there are no corresponding indexes and that query results in full table scan:
Query:
Plan:
After adding the index, the plan improves drastically.
Updated plan:
Changes
Testing
./scripts/develop.sh, connected to the local PostgreSQL instance, inspected the indexes to make sure new index is there: