- Notifications
You must be signed in to change notification settings - Fork1.1k
fix(site): remove hardcoded max-width on task display name in sidebar#20934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
david-fraley wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Remove the `max-w-[220px]` constraint from the task display name spanin the sidebar. This constraint was causing unnecessary truncation evenwhen there was available space.The sidebar has a fixed width of 256px (w-64), and the flex containeralready handles spacing correctly. By removing the arbitrary max-widthand keeping just the `truncate` class, the text now uses all availablespace in the flex container before truncating.Also removed the `block` class as it's not needed in a flex container.Fixes#20932🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the task display name truncation issue in the sidebar where text was being unnecessarily ellipsized even when there was plenty of available space.
Root Cause
PR#20918 added a hardcoded
max-w-[220px]constraint to the task display name span. This was too restrictive given the sidebar's fixed width of 256px (w-64), causing unnecessary truncation.Changes
max-w-[220px]constraint from task display name spanblockclass (not needed in flex container)truncateclass for genuine overflow casesTesting
pnpm lint)pnpm format)Visual Impact
Task display names now use the full available width (~220-230px depending on spacing) before truncating, while maintaining:
Risk Assessment
Low risk: Single-line CSS change affecting only visual presentation.
Fixes#20932
🤖 Generated withClaude Code