Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): use display name field for tasks#20918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ssncferreira merged 2 commits intomainfromssncferreira/site-tasks-display-name
Nov 25, 2025

Conversation

@ssncferreira
Copy link
Contributor

@ssncferreirassncferreira commentedNov 25, 2025•
edited
Loading

Description

This PR updates the frontend to use the newdisplay_name field for tasks. In the tasks list view,display_name replacesinitial_prompt, and in the tasks sidebar,display_name replacesname. This is a follow-up to#20856, which introduced thedisplay_name field in the backend.

Changes

  • Displaytask.display_name instead oftask.initial_prompt in the tasks table
  • Displaytask.display_name instead oftask.name in the task sidebar view
  • Updated mock data to includedisplay_name for all test tasks
  • Added Storybook story to showcase display name rendering with different lengths (short, max length with ellipsis, and edge cases)

Follow-up:#20856
Closes:#20801

@ssncferreirassncferreiraforce-pushed thessncferreira/site-tasks-display-name branch 4 times, most recently fromf613ff0 to576fe31CompareNovember 25, 2025 15:13
@ssncferreirassncferreiraforce-pushed thessncferreira/site-tasks-display-name branch from576fe31 tof449045CompareNovember 25, 2025 15:18
@ssncferreirassncferreira marked this pull request as ready for reviewNovember 25, 2025 15:19
Copy link
Contributor

@DanielleMaywoodDanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approving under the assumption we're happy for the task name to remain where I've drawn the arrow

image

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! 👍🏻

Re:@DanielleMaywood's concern, I think the name is more suitable there than the display name (especially considering space constraints), but it could be a bit confusing. I think we can wait for customer feedback on this, though.

@ssncferreira
Copy link
ContributorAuthor

ssncferreira commentedNov 25, 2025•
edited
Loading

Approving under the assumption we're happy for the task name to remain where I've drawn the arrow

image

I also had that question, but I think it makes sense to keep showing the task name because we already show the display name in the sidebar. This way, the user is able to more easily identify which task name is associated with the task display name.

Additionally, since the workspace name matches the task name, showing the task name in the top bar helps users connect the task to its associated workspace when navigating between views.

Started an internal thread on slack regarding this topic:https://codercom.slack.com/archives/C0992H8HGCS/p1764086497375829

@ssncferreirassncferreira merged commit2f399ea intomainNov 25, 2025
31 checks passed
@ssncferreirassncferreira deleted the ssncferreira/site-tasks-display-name branchNovember 25, 2025 16:29
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 25, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredrimafredri approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

Assignees

@ssncferreirassncferreira

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add display name field for tasks

4 participants

@ssncferreira@mafredri@DanielleMaywood
[8]ページ先頭
©2009-2025 Movatter.jp