Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

perf: optimize migration 371 to run faster on large deployments#20906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 4 commits intomainfromgeokat/20899-optimize-migration-371
Nov 26, 2025

Conversation

@geokat
Copy link
Contributor

@geokatgeokat commentedNov 24, 2025•
edited
Loading

closes#20899

This is in response to a migration in v2.27 that takes very long on deployments with largeapi_keys tables.

NOTE: The optimization causes theup migration to delete old data (keys that expired more than 7 days ago). Thedown migration won't resurrect the deleted data.

@geokatgeokat requested a review fromEmyrkNovember 24, 2025 19:45
@codercoder deleted a comment fromgithub-actionsbotNov 24, 2025
@codercoder deleted a comment fromgithub-actionsbotNov 24, 2025
@geokatgeokat requested a review fromEmyrkNovember 24, 2025 23:33
@codercoder deleted a comment fromgithub-actionsbotNov 25, 2025
@geokatgeokat marked this pull request as ready for reviewNovember 25, 2025 00:53
@codercoder deleted a comment fromgithub-actionsbotNov 25, 2025
@github-actions
Copy link

github-actionsbot commentedNov 25, 2025•
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by theCLA Assistant Lite bot.

@geokat
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

cdrci2 added a commit to coder/cla that referenced this pull requestNov 25, 2025
@geokatgeokatforce-pushed thegeokat/20899-optimize-migration-371 branch from5f4307d to47bba5bCompareNovember 25, 2025 19:14
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good! I'll stamp after a meeting about this Wednesday morning CST

Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just blocking a merge for now. Will stamp again

@EmyrkEmyrk merged commita926157 intomainNov 26, 2025
30 checks passed
@EmyrkEmyrk deleted the geokat/20899-optimize-migration-371 branchNovember 26, 2025 03:45
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 26, 2025
@EmyrkEmyrk added the cherry-pick/v2.29Needs to be cherry-picked to the 2.29 release branch labelNov 26, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@EmyrkEmyrkEmyrk approved these changes

@ThomasK33ThomasK33Awaiting requested review from ThomasK33

@spikecurtisspikecurtisAwaiting requested review from spikecurtis

Assignees

@geokatgeokat

Labels

cherry-pick/v2.29Needs to be cherry-picked to the 2.29 release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimize migration 371, very slow on databases with large amount of api_keys

4 participants

@geokat@dannykopping@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp