Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): add tab to invalidate prebuilds#20864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 14 commits intomainfrom17917-invalidation-ui-2
Nov 28, 2025
Merged

Conversation

@mtojek
Copy link
Member

@mtojekmtojek commentedNov 21, 2025•
edited
Loading

Updates#17917

This PR adds another tab to the Template page, which should be visible for Premium licenses and template admins.

Screenshot 2025-11-24 at 18 27 36

In the follow-up, I'll update the docs.

@mtojekmtojek self-assigned thisNov 21, 2025
@mtojekmtojek marked this pull request as ready for reviewNovember 24, 2025 18:02
Copy link
Contributor

@ssncferreirassncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall LGTM, aside from minor fixes including updating the API endpoint middleware to check for the prebuilds feature entitlement instead of template RBAC.

One enhancement for future consideration: in the workspace list view, invalidated prebuilt workspaces could display a small indicator icon that shows something like "This prebuild is invalidated and will be removed in the next reconciliation loop" on hover, similar to the outdated workspace indicator (see screenshot). This would be a nice-to-have and can be addressed in a separate PR.

Screenshot 2025-11-26 at 12 29 06

mtojek added a commit that referenced this pull requestNov 26, 2025
@mtojekmtojek marked this pull request as draftNovember 26, 2025 15:51
Copy link
MemberAuthor

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One enhancement for future consideration: in the workspace list view, invalidated prebuilt workspaces could display a small indicator icon that shows something like "This prebuild is invalidated and will be removed in the next reconciliation loop" on hover, similar to the outdated workspace indicator (see screenshot). This would be a nice-to-have and can be addressed in a separate PR.

This is a valid call, but it involves modifying the workspaces endpoint, so definitely another issue/pull request 👍 Thanks for the suggestion!

ssncferreira reacted with heart emoji
@mtojekmtojek marked this pull request as ready for reviewNovember 27, 2025 11:15
Copy link
Contributor

@ssncferreirassncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM ✅ Nice work 🎉

mtojek reacted with hooray emoji
@mtojekmtojek merged commita8862be intomainNov 28, 2025
31 of 33 checks passed
@mtojekmtojek deleted the 17917-invalidation-ui-2 branchNovember 28, 2025 07:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 28, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ssncferreirassncferreirassncferreira approved these changes

@aslilacaslilacAwaiting requested review from aslilac

Assignees

@mtojekmtojek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mtojek@aslilac@ssncferreira
[8]ページ先頭
©2009-2025 Movatter.jp