Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: remove inflight interceptions from aibridge returned values#20852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jakehwll merged 13 commits intomainfromjakehwll/remove-inflight-interceptions
Nov 24, 2025

Conversation

@jakehwll
Copy link
Contributor

Addressesaibridge#54

When querying against the values in the database for/api/experimental/aibridge/interceptions we found strange behaviour wherein there was interceptions that lacked prompting and other various fields we want. Generally this was as a result of the data not actually existing for these values (as they were inflight).

The simple solution to this was to hide them if they didn't exist. This PR addresses that.

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@jakehwll we never make changes without tests to validate.
Please can you add some to cover each query?

@jakehwll
Copy link
ContributorAuthor

@jakehwll we never make changes without tests to validate.

Please can you add some to cover each query?

Yeah this was meant to Draft PR oops

@jakehwlljakehwll marked this pull request as draftNovember 23, 2025 22:53
@jakehwlljakehwll marked this pull request as ready for reviewNovember 24, 2025 12:18
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, a couple small things to fix

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ship it 👍

@jakehwlljakehwll merged commitca560d3 intomainNov 24, 2025
30 checks passed
@jakehwlljakehwll deleted the jakehwll/remove-inflight-interceptions branchNovember 24, 2025 23:23
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@mtojekmtojekmtojek approved these changes

@DanielleMaywoodDanielleMaywoodAwaiting requested review from DanielleMaywood

Assignees

@jakehwlljakehwll

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jakehwll@dannykopping@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp