Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: refactor ConvertState#20833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@Emyrk
Copy link
Member

No description provided.

golden file test is to prevent regressions in behavior. It is goingto be used as a benchmark for a refactor
@EmyrkGraphite App
Copy link
MemberAuthor

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
Learn more

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@EmyrkEmyrkforce-pushed thestevenmasley/convert_state_refactor_actual branch fromc59347a to776d072CompareNovember 19, 2025 18:08
@EmyrkEmyrkforce-pushed thestevenmasley/convert_state_refactor_actual branch from776d072 toe69b729CompareNovember 19, 2025 18:11
@EmyrkEmyrkforce-pushed thestevenmasley/convert_state_refactor branch from6849ee9 to7cbbc20CompareNovember 19, 2025 18:11
@EmyrkEmyrkforce-pushed thestevenmasley/convert_state_refactor_actual branch from8a17e17 to743e3b8CompareNovember 20, 2025 18:27
@EmyrkEmyrkforce-pushed thestevenmasley/convert_state_refactor_actual branch from743e3b8 to41c6890CompareNovember 20, 2025 18:30
@EmyrkEmyrkforce-pushed thestevenmasley/convert_state_refactor branch from57ea109 to2ee6b40CompareNovember 20, 2025 18:30
Base automatically changed fromstevenmasley/convert_state_refactor tomainNovember 21, 2025 13:27
@Emyrk
Copy link
MemberAuthor

AI did pretty good, but I'm not sure this is really any better. The state being held in a struct just means you never know what values are populated and what is not. So very error prone still.

@EmyrkEmyrk closed thisNov 24, 2025
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

@EmyrkEmyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp