- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: fix build timeline to include entire stage timings#20805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e80baae to89cc16cCompareEmyrk commentedNov 17, 2025
@dannykopping the storybook failures are happening in I am watching this PR with fixes:#20808 |
73687e5 to80631dfCompareEmyrk commentedNov 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
dannykopping left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Uh oh!
There was an error while loading.Please reload this page.
aff2080 intomainUh oh!
There was an error while loading.Please reload this page.

Uh oh!
There was an error while loading.Please reload this page.
There is a "bug" in build timlines. The timelines are populated by discrete events. These events may not inherently include the actual total time for a given stage (plan, apply, graph, etc). Ideally we would measure the total time for a given terraform execution stage, then populate the timeline with the discrete events.
See this live example. The stages are:
init= 11.47splan=864msgraph=10.06sapply= 23.88s46.27s is the total duration summed, however the timings suggest this took >1m.
Where was the ~14+ seconds taken? Without full stage timings, we are not really sure.
Fix example
This is the exact same build timings, with the stage boundary entry removed in the
Before. You can seeplangoes from462ms -> 727msandapplyfrom552ms -> 900ms.Before
After
Future work
graphstage is currently not using this method. Because there is 2 graph stages, and they have to be distinct. Working on this in another PRUI Demo
Screencast.From.2025-11-17.11-38-16.webm