Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: fix build timeline to include entire stage timings#20805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 18 commits intomainfromstevenmasley/wholetimings
Nov 19, 2025

Conversation

@Emyrk
Copy link
Member

@EmyrkEmyrk commentedNov 17, 2025
edited
Loading

There is a "bug" in build timlines. The timelines are populated by discrete events. These events may not inherently include the actual total time for a given stage (plan, apply, graph, etc). Ideally we would measure the total time for a given terraform execution stage, then populate the timeline with the discrete events.

See this live example. The stages are:

  • init = 11.47s
  • plan =864ms
  • graph =10.06s
  • apply = 23.88s

46.27s is the total duration summed, however the timings suggest this took >1m.

Screenshot From 2025-11-13 13-32-07

Where was the ~14+ seconds taken? Without full stage timings, we are not really sure.

Fix example

This is the exact same build timings, with the stage boundary entry removed in theBefore. You can seeplan goes from462ms -> 727ms andapply from552ms -> 900ms.

Before

Screenshot From 2025-11-17 10-32-01

After

Screenshot From 2025-11-17 10-29-37Screenshot From 2025-11-17 10-27-03

Future work

  • We should be recording more time entries for what is happening inside this missing overhead. This just captures the missing timeline in the overview.
  • UI should be reworked to look nicer.
  • Thegraph stage is currently not using this method. Because there is 2 graph stages, and they have to be distinct. Working on this in another PR

UI Demo

Screencast.From.2025-11-17.11-38-16.webm

@EmyrkEmyrk changed the titlefeat: include entire stage timings in build timelinefeat: fix build timeline to include entire stage timingsNov 17, 2025
@EmyrkEmyrk marked this pull request as ready for reviewNovember 17, 2025 17:46
@EmyrkEmyrkforce-pushed thestevenmasley/wholetimings branch frome80baae to89cc16cCompareNovember 17, 2025 19:22
@Emyrk
Copy link
MemberAuthor

@dannykopping the storybook failures are happening inmain.

I am watching this PR with fixes:#20808

@EmyrkEmyrkforce-pushed thestevenmasley/wholetimings branch from73687e5 to80631dfCompareNovember 18, 2025 16:32
@EmyrkGraphite App
Copy link
MemberAuthor

Emyrk commentedNov 18, 2025
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@EmyrkEmyrk merged commitaff2080 intomainNov 19, 2025
34 of 35 checks passed
@EmyrkEmyrk deleted the stevenmasley/wholetimings branchNovember 19, 2025 15:35
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

Assignees

@EmyrkEmyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Emyrk@dannykopping

[8]ページ先頭

©2009-2025 Movatter.jp