Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add timing flag context to warn message#20772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 1 commit intomainfromdk/timing-flags
Nov 14, 2025
Merged
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletioncoderd/provisionerdserver/metrics.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -153,6 +153,9 @@ func (m *Metrics) UpdateWorkspaceTimingsMetrics(
m.workspaceClaimTimings.
WithLabelValues(organizationName, templateName, presetName).Observe(buildTime)
default:
m.logger.Warn(ctx, "unsupported workspace timing flags")
m.logger.Warn(ctx, "unsupported workspace timing flags",
"isPrebuild", flags.IsPrebuild,
"isClaim", flags.IsClaim,
"isWorkspaceFirstBuild", flags.IsFirstBuild)
Comment on lines +156 to +159
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: might be also worth to add

Suggested change
m.logger.Warn(ctx,"unsupported workspace timing flags",
"isPrebuild",flags.IsPrebuild,
"isClaim",flags.IsClaim,
"isWorkspaceFirstBuild", flags.IsFirstBuild)
m.logger.Warn(ctx,"unsupported workspace timing flags",
"organizationName",organizationName,
"templateName",templateName,
"presetName",presetName,
"isPrebuild",flags.IsPrebuild,
"isClaim",flags.IsClaim,
"isWorkspaceFirstBuild", flags.IsFirstBuild)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Whoops, I had auto-merge enabled!

}
}
Loading
[8]ページ先頭
©2009-2025 Movatter.jp