- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: add timing flag context to warn message#20772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Danny Kopping <danny@coder.com>
ssncferreira left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
| m.logger.Warn(ctx,"unsupported workspace timing flags", | ||
| "isPrebuild",flags.IsPrebuild, | ||
| "isClaim",flags.IsClaim, | ||
| "isWorkspaceFirstBuild",flags.IsFirstBuild) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: might be also worth to add
| m.logger.Warn(ctx,"unsupported workspace timing flags", | |
| "isPrebuild",flags.IsPrebuild, | |
| "isClaim",flags.IsClaim, | |
| "isWorkspaceFirstBuild", flags.IsFirstBuild) | |
| m.logger.Warn(ctx,"unsupported workspace timing flags", | |
| "organizationName",organizationName, | |
| "templateName",templateName, | |
| "presetName",presetName, | |
| "isPrebuild",flags.IsPrebuild, | |
| "isClaim",flags.IsClaim, | |
| "isWorkspaceFirstBuild", flags.IsFirstBuild) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Whoops, I had auto-merge enabled!
86c4948 intomainUh oh!
There was an error while loading.Please reload this page.
prometheus.provisionerd_server_metrics: unsupported workspace timing flagsappears in the logs, but without knowledge of the available flags it's not possible to troubleshoot this.