Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: send all params instead of only touched params#20740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 1 commit intomainfromjaaydenh/workspace-parameters-fix
Nov 13, 2025

Conversation

@jaaydenh
Copy link
Contributor

resolves#20257

Ensure all parameters are sent in the web socket request instead of only touched parameters.

Using touched parameters is irrelevant for the workspace parameters page in workspace settings because parameters that appear here have already been chosen by the user during workspace creation. So all parameters should be sent in the web socket request whether have been touched in the form or not.

@jaaydenhjaaydenh self-assigned thisNov 12, 2025
@Emyrk
Copy link
Member

Is this only on the workspace settings page? I ask because on the workspace created, untouched is important to leave unsent

@jaaydenh
Copy link
ContributorAuthor

@Emyrk yes, this is only for the workspace settings page. It feels like this is the fundamental difference between the create workspace page and the workspace settings page that was missed originally.

Emyrk reacted with thumbs up emoji

@jaaydenhjaaydenh merged commit14f0844 intomainNov 13, 2025
33 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/workspace-parameters-fix branchNovember 13, 2025 13:00
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 13, 2025
david-fraley pushed a commit that referenced this pull requestNov 14, 2025
david-fraley pushed a commit that referenced this pull requestNov 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Parameters hidden by default have their values reset to default when unrelated parameter value modified on existing workspace

4 participants

@jaaydenh@Emyrk@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp