Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore!: allow coder MCP tools to not be injected#20713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dannykopping wants to merge4 commits intomain
base:main
Choose a base branch
Loading
fromdk/inject-coder-mcp

Conversation

@dannykopping
Copy link
Contributor

@dannykoppingdannykopping commentedNov 11, 2025
edited
Loading

Currently, when AI Bridge is enabled AND theoauth2 andmcp-server-http experiments are enabled we inject Coder's MCP tools into all intercepted AI Bridge requests.

This PR introduces a config to control this behaviour.

NOTE: this is a backwards-incompatible change; previously these tools would be injected automatically, now this setting will need to be explicitly enabled.

Signed-off-by: Danny Kopping <danny@coder.com>
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suggest we make this opt in i.e. make the default value false. I know it's a breaking change but it's fine given not every client needs the coder MCP tools.

We will plan on a more granular per user/template config for MCP servers/tools for future roadmap.

@dannykopping
Copy link
ContributorAuthor

I suggest we make this opt in i.e. make the default value false. I know it's a breaking change but it's fine given not every client needs the coder MCP tools.

OK. We will need to call it out in the next release's notes in that case.

matifali reacted with thumbs up emoji

@dannykoppingdannykopping changed the titlechore: allow coder MCP tools to not be injected!chore: allow coder MCP tools to not be injectedNov 11, 2025
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykoppingdannykopping changed the title!chore: allow coder MCP tools to not be injectedchore!: allow coder MCP tools to not be injectedNov 11, 2025
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykoppingdannykopping marked this pull request as ready for reviewNovember 11, 2025 13:00
@github-actionsgithub-actionsbot added the release/breakingThis label is applied to PRs to detect breaking changes as part of the release process labelNov 11, 2025
Comment on lines +112 to +115
--aibridge-inject-coder-mcp-tools bool, $CODER_AIBRIDGE_INJECT_CODER_MCP_TOOLS (default: false)
Whether to inject Coder's MCP tools into intercepted AI Bridge
requests (requires the "oauth2" and "mcp-server-http" experiments to
be enabled).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I assume this will not require the other experiments flags (http-mcp-server,oauth2) when they graduate from the experiment.

Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The flow looks good to me. Thanks.

YAML:"bedrock_small_fast_model",
},
{
Name:"AIBridge Inject Coder MCP tools",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Name:"AIBridge Inject Coder MCP tools",
Name:"AI Bridge Inject Coder MCP tools",

I think we useAI Bridge more thanAIBridge

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@matifalimatifalimatifali approved these changes

@pawbanapawbanaAwaiting requested review from pawbana

Assignees

@dannykoppingdannykopping

Labels

release/breakingThis label is applied to PRs to detect breaking changes as part of the release process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dannykopping@matifali

[8]ページ先頭

©2009-2025 Movatter.jp