Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: record user agent in interception metadata#20695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
pawbana wants to merge1 commit intomain
base:main
Choose a base branch
Loading
from10-30-pb-aibridge-intc-user-agent-metadata

Conversation

@pawbana
Copy link
Contributor

@pawbanapawbana commentedNov 10, 2025
edited
Loading

Adds user agent to interception metadata
Requires:coder/aibridge#47
Fixes:coder/aibridge#31
Fixes:coder/aibridge#20

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's unfortunate that this PR referencescoder/aibridge#31, since that contains no context.

coder/aibridge#20 is the parent issue, and it contains some more details. Perhaps you missed this one? I'm not sure why we structured the issue like this 😞

I don't think we should just simply capture the UA because 1) it may not be useful and 2) we'll need to aggregate by client at some point and doing so on an infinite set of possible UAs will be very difficult.

We should do the client detection in Bridge and pass through a known set of client names.

At the very least I think this needs a (mini) RFC to discuss how we do this detection and what we do if a new (or as yet unknown) client is used.

@pawbanapawbanaforce-pushed the10-30-pb-aibridge-intc-user-agent-metadata branch fromb481835 tob770eebCompareNovember 10, 2025 16:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dannykoppingdannykoppingdannykopping requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@pawbanapawbana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Collect user agent as metadata for interceptions Identify client by User-Agent or other means

3 participants

@pawbana@dannykopping

[8]ページ先頭

©2009-2025 Movatter.jp