- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: record user agent in interception metadata#20695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
dannykopping left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's unfortunate that this PR referencescoder/aibridge#31, since that contains no context.
coder/aibridge#20 is the parent issue, and it contains some more details. Perhaps you missed this one? I'm not sure why we structured the issue like this 😞
I don't think we should just simply capture the UA because 1) it may not be useful and 2) we'll need to aggregate by client at some point and doing so on an infinite set of possible UAs will be very difficult.
We should do the client detection in Bridge and pass through a known set of client names.
At the very least I think this needs a (mini) RFC to discuss how we do this detection and what we do if a new (or as yet unknown) client is used.
b481835 tob770eebCompare
Uh oh!
There was an error while loading.Please reload this page.
Adds user agent to interception metadata
Requires:coder/aibridge#47
Fixes:coder/aibridge#31
Fixes:coder/aibridge#20