- Notifications
You must be signed in to change notification settings - Fork1k
feat: Add links to the resource card for workspace applications#2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This was broken when improving the build times. The typecheckerunfortunately missed it!
| userName={workspace.owner_name} | ||
| workspaceName={workspace.name} | ||
| /> | ||
| ))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would wrap these insides of aStack to add some spacing between the items inside of this column. I would also add a default icon or a left margin if it does not have one to be aligned with the terminal to avoid the situation below:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The code looks good to me, just a minor observation related to the design.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#1907 and#805.
I'll make this pretty in another PR!
This error screen is displayed when an application isn't reachable.