Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(coderd/provisionerdserver): address flake in TestServer_ExpirePrebuildsSessionToken#20648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@johnstcn
Copy link
Member

Addresses a flake seen locally by@mafredri:

panic: interface conversion: proto.isAcquiredJob_Type is nil, not *proto.AcquiredJob_WorkspaceBuild_ [recovered]        panic: interface conversion: proto.isAcquiredJob_Type is nil, not *proto.AcquiredJob_WorkspaceBuild_goroutine 77 [running]:testing.tRunner.func1.2({0x35ba440, 0xc000f15620})        /usr/local/go/src/testing/testing.go:1734 +0x21ctesting.tRunner.func1()        /usr/local/go/src/testing/testing.go:1737 +0x35epanic({0x35ba440?, 0xc000f15620?})        /usr/local/go/src/runtime/panic.go:792 +0x132github.com/coder/coder/v2/coderd/provisionerdserver_test.TestServer_ExpirePrebuildsSessionToken(0xc00010d500)                                 /home/coder/coder/coderd/provisionerdserver/provisionerdserver_test.go:4128 +0xc4btesting.tRunner(0xc00010d500, 0x4bd8450)        /usr/local/go/src/testing/testing.go:1792 +0xf4created by testing.(*T).Run in goroutine 1        /usr/local/go/src/testing/testing.go:1851 +0x413FAIL    github.com/coder/coder/v2/coderd/provisionerdserver     20.830sFAIL

It's unclear why this would happen in the first place.

@johnstcnjohnstcn self-assigned thisNov 3, 2025
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

?!

@johnstcnjohnstcn merged commit1961252 intomainNov 3, 2025
32 checks passed
@johnstcnjohnstcn deleted the cj/flake/provisionerdserver-acquire-job-type branchNovember 3, 2025 11:39
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@johnstcnjohnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnstcn@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp